Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented May 6, 2024

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels May 6, 2024
@seisman seisman modified the milestone: 0.13.0 May 6, 2024
@seisman seisman changed the title CI: Unpin NumPy in the "GMT Dev Tests" workflow (#3208)" CI: Unpin NumPy in the GMT Dev Tests workflow (#3208) Jun 17, 2024
@seisman
Copy link
Member Author

seisman commented Jun 17, 2024

The "GMT Dev Tests" workflow passed four days ago (https://github.com/GenericMappingTools/pygmt/actions/runs/9508848053/job/26210865246) but suddenly failed 12 hours ago (https://github.com/GenericMappingTools/pygmt/actions/runs/9540235948/job/26291686980).

There are no changed on the GMT side, so it's likely due to a broken library installed by conda-forge.

I think we can go with this PR and find out why the workflow fails on Windows later.

@seisman seisman added this to the 0.13.0 milestone Jun 17, 2024
@seisman seisman marked this pull request as ready for review June 17, 2024 13:42
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, I think we can go with this to handle compatibility between NumPy 1.x and 2.0.

Btw, do you want to bump the NumPy version on ci_tests.yml after this? Or we keep testing NumPy 1.26 for a few more months?

numpy-version: '1.26'

@weiji14 weiji14 added run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR and removed run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Jun 18, 2024
@seisman
Copy link
Member Author

seisman commented Jun 18, 2024

Btw, do you want to bump the NumPy version on ci_tests.yml after this? Or we keep testing NumPy 1.26 for a few more months?

Tried in 3fc0156, but there are dependency issues
https://github.com/GenericMappingTools/pygmt/actions/runs/9537393685/job/26285444415?pr=3226. It seems some packages are not updated to work with NumPy 2.0

@seisman seisman merged commit 8076db4 into main Jun 18, 2024
@seisman seisman deleted the ci/unpin-numpy branch June 18, 2024 05:31
@seisman seisman changed the title CI: Unpin NumPy in the GMT Dev Tests workflow (#3208) CI: Unpin NumPy in the GMT Dev Tests workflow and fix the dataarray_to_matrix doctest (#3208) Jun 18, 2024
@seisman
Copy link
Member Author

seisman commented Jun 18, 2024

Btw, do you want to bump the NumPy version on ci_tests.yml after this? Or we keep testing NumPy 1.26 for a few more months?

Tried in 3fc0156, but there are dependency issues https://github.com/GenericMappingTools/pygmt/actions/runs/9537393685/job/26285444415?pr=3226. It seems some packages are not updated to work with NumPy 2.0

I think the dependency issue has been resolved. See #3292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing doctest on pygmt.clib.conversion.dataarray_to_matrix with NumPy 2.0

3 participants