Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 27, 2023

Description of proposed changes

Change tilemap source from contextily's default Stamen Terrain to OpenStreetmap's Standard tile layer (osm-carto, see https://wiki.openstreetmap.org/wiki/Standard_tile_layer).

References:

Addresses #2699

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Change tilemap source from contextily's default Stamen Terrain to OpenStreetmap's Standard tile layer (https://wiki.openstreetmap.org/wiki/Standard_tile_layer).
@weiji14 weiji14 self-assigned this Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_tilemap_no_clip_False.png
modified pygmt/tests/baseline/test_tilemap_no_clip_True.png
modified pygmt/tests/baseline/test_tilemap_ogc_wgs84.png
modified pygmt/tests/baseline/test_tilemap_web_mercator.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_tilemap_no_clip_False.png
test_tilemap_no_clip_True.png
test_tilemap_ogc_wgs84.png
test_tilemap_web_mercator.png

Report last updated at commit 0e04187

@weiji14
Copy link
Member Author

weiji14 commented Sep 27, 2023

Some small differences in generated images due to differing ghostscript versions. CI is using gs 9.54, whereas I was using gs 9.56 in 49cd040. Trying with gs 10.02 (xref #2694) at 7ee18ab.

@weiji14 weiji14 marked this pull request as ready for review September 27, 2023 20:05
@weiji14 weiji14 changed the title Change tilemap source to OpenStreetMap CI: Change tilemap source to OpenStreetMap Sep 28, 2023
@weiji14 weiji14 changed the title CI: Change tilemap source to OpenStreetMap CI: Change tilemap source from Stamen to OpenStreetMap Sep 28, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 28, 2023
@seisman seisman added this to the 0.11.0 milestone Sep 28, 2023
@seisman seisman merged commit c34e822 into main Sep 28, 2023
@seisman seisman deleted the tilemap-osm branch September 28, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants