Skip to content

Conversation

@willschlitzer
Copy link
Contributor

This replaces load_ocean_ridge_points with _load_ocean_ridge_points.

It also changes the argument sep=r"\s+" to delim_whitespace=True.

Addresses: #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the deprecation Deprecating a feature label Jan 4, 2023
@willschlitzer willschlitzer added this to the 0.9.0 milestone Jan 4, 2023
@willschlitzer willschlitzer self-assigned this Jan 4, 2023
willschlitzer and others added 2 commits January 6, 2023 07:05
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 6, 2023
@seisman seisman merged commit 203c30b into main Jan 14, 2023
@seisman seisman deleted the deprecate-load_ocean_ridge_points branch January 14, 2023 04:15
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants