Skip to content

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

Related to #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund self-assigned this Jan 4, 2023
michaelgrund and others added 2 commits January 5, 2023 14:02
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Jan 16, 2023
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except a minor comment.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 16, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 18, 2023
@seisman seisman merged commit 9b41750 into main Jan 18, 2023
@seisman seisman deleted the deprecate-load_sample_bathymetry branch January 18, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants