Skip to content

Conversation

@willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Jan 4, 2023

Removes the deprecated function load_mars_shape and replaces it with _load_mars_shape.

Addresses: #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the deprecation Deprecating a feature label Jan 4, 2023
@willschlitzer willschlitzer added this to the 0.9.0 milestone Jan 4, 2023
@willschlitzer willschlitzer self-assigned this Jan 4, 2023
willschlitzer and others added 5 commits January 6, 2023 07:00
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@michaelgrund
Copy link
Member

Before we continue, please solve the conflicts @willschlitzer 😉

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
if name in load_func_old:
data = load_func_old[name](suppress_warning=True)
elif name in load_func:
if name in load_func:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already checked if a valid name is given at line 66, so no need to check if name in load_func.

Please change:

if name in load_func:
    data = load_func[name]()
return data

to

return load_func[name]()

@seisman
Copy link
Member

seisman commented Jan 30, 2023

Kindly ping @willschlitzer to see if you have time to finalize this PR.

@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 30, 2023
@willschlitzer
Copy link
Contributor Author

Kindly ping @willschlitzer to see if you have time to finalize this PR.

Apologies for the delay; visited family over the weekend (I'm going to be an uncle! 🥳 ).

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 31, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 31, 2023
@seisman seisman merged commit 62e5067 into main Jan 31, 2023
@seisman seisman deleted the deprecate-load_mars_shape branch January 31, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants