Skip to content

Clarify non-implemented options in sph2grd.rst#8915

Open
ZMAlt wants to merge 1 commit intoGenericMappingTools:masterfrom
ZMAlt:patch-1
Open

Clarify non-implemented options in sph2grd.rst#8915
ZMAlt wants to merge 1 commit intoGenericMappingTools:masterfrom
ZMAlt:patch-1

Conversation

@ZMAlt
Copy link
Contributor

@ZMAlt ZMAlt commented Mar 7, 2026

Added notes indicating that options -D and -E are not implemented yet.

gmt/src/sph2grd.c

Lines 156 to 165 in 0fbea58

case 'D': /* Evaluate derivative solutions */
n_errors += gmt_M_repeated_module_option (API, Ctrl->D.active);
n_errors += gmt_get_required_char (GMT, opt->arg, opt->option, 0, &Ctrl->D.mode);
GMT_Report (API, GMT_MSG_ERROR, "Comment -D: Not implemented yet.\n");
break;
case 'E': /* Evaluate on ellipsoid */
n_errors += gmt_M_repeated_module_option (API, Ctrl->E.active);
GMT_Report (API, GMT_MSG_ERROR, "Comment -E: Not implemented yet.\n");
break;
case 'F': /* Bandpass or Gaussian filter -F[k]<lc>/<lp>/<hp>/<hc> or -F[k]<lo>/<hi>*/

Description of proposed changes

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Added notes indicating that options -D and -E are not implemented yet.
@seisman
Copy link
Member

seisman commented Mar 7, 2026

Perhaps we should remove the options if they are not implemented.

@joa-quim
Copy link
Member

joa-quim commented Mar 7, 2026

Yes, that would be better. From memory sph2grd is a very broken module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants