Migrate model/metadata loading from wandb to HuggingFace#54
Open
avantikalal wants to merge 4 commits into
Open
Migrate model/metadata loading from wandb to HuggingFace#54avantikalal wants to merge 4 commits into
avantikalal wants to merge 4 commits into
Conversation
…t markers Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Add HF_MODEL_REPO, HF_DATA_REPO, HF_METADATA_FILENAME constants - Rewrite hub/__init__.py to use hf_hub_download (fixes broken grelu.resources import) - Add hub/wandb.py for internal/private model access via wandb.Api() - Update hub/download.py to use hf_hub_download with local_dir - Remove login_wandb() from conftest.py (HF is public, no auth needed) - Update test_hub.py with hf/wandb markers Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
tox>=4.24 uses dataclass(slots=True) which requires Python 3.10+. pipx run was downloading latest tox regardless of the pip-installed version. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grelu.resources.get_artifact()/ wandb-based loading withhf_hub_downloadfrom HuggingFace HubGenentech/decima-model, metadata:Genentech/decima-datadecima.hub.wandbsubmodule (useswandb.Api()directly, no gReLU dependency)>=1.0.10)Changes
src/decima/constants.pyHF_MODEL_REPO,HF_DATA_REPO,HF_METADATA_FILENAMEsrc/decima/hub/__init__.pysrc/decima/hub/wandb.pywandb.Api()directlysrc/decima/hub/download.pyhf_hub_downloadwithlocal_dirsetup.cfghuggingface_hubdep, addwandb/hfpytest markerstests/test_hub.py@pytest.mark.hftests/conftest.pylogin_wandb()call (HF is public)Internal user migration
Test plan
test_hf_constants— constants correctpytest -m "not wandb and not hf and not long_running"test_load_resultpasses (downloadsmetadata.h5adfrom HF, ~3.3 GB)@pytest.mark.hftests (full model download) — require HF network access@pytest.mark.wandbtests — require wandb credentials🤖 Generated with Claude Code