Fix to load new themes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themeCache would cache previously used styles even if the theme was changed. With this change, styles are recalculated from the top but parent lookups will still be fetched from the cache as before.
Author
|
@shivrajkumar Any updates on this PR |
|
Having this issue as well. This patch works for me. Thanks @chaitanya0bhagvan hopefully it gets merged one day. |
|
I am having an issue with dynamic custom themes and this helped me. Thanks @chaitanya0bhagvan |
retailos
pushed a commit
to retailos/theme
that referenced
this pull request
Dec 15, 2017
retailos
pushed a commit
to retailos/NativeBase
that referenced
this pull request
Dec 18, 2017
|
+1 We would benefit from this patch as well. |
|
+1 Also it would be great to have API to invalidate the cache somehow. |
|
+1 |
|
+1 Still a problem here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
themeCache would cache previously used styles even if the theme was changed. With this change, styles are recalculated from the top but parent lookups will still be fetched from the cache as before.