fix: Select field breaks forms in safari#5685
Open
gfviegas wants to merge 2 commits intoGeekyAnts:masterfrom
Open
fix: Select field breaks forms in safari#5685gfviegas wants to merge 2 commits intoGeekyAnts:masterfrom
gfviegas wants to merge 2 commits intoGeekyAnts:masterfrom
Conversation
|
@gfviegas is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
gfviegas
changed the title
gfviegas
commented
Mar 1, 2023
|
Good catch! This should also be applied to |
|
Any chance that this can be merged, please? I'm having to use an old version of native-base because of this bug and this PR fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5111
Summary
When a Select is present on a form rendered on Safari (both iOS and Mac tested), every change in ANY input (even others than the Select) causes the screen to focus on the select input and loses focus on the changing input.
This PR aims to fix #5111 . There's a minimal reproduction of the problem this PR solves in this issue.