Fix incomplete wallet creation example in testing documentation#1
Open
Fix incomplete wallet creation example in testing documentation#1
Conversation
- Updated wallet creation example with required parameters - Added explanatory comments about use_password and overwrite - Fixed assertion to check actual wallet properties - Updated explanation text for clarity This fixes the documentation bug where create_new_coldkey() was shown without required parameters, which would cause errors for developers following the testing guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The testing documentation in
contrib/TESTING.mdshows an incomplete example of wallet creation that would cause errors for developers trying to follow it.Fix
Updated the documentation to show the correct usage with required parameters.
Verification
Verified against actual test files in the codebase.