Skip to content

Dbe3715 bq decimal issue #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramyamasani wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dbe3715 bq decimal issue #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9278a86
DBE-3715 BQ Decimal issue
Dec 31, 2025
4f19b2b
DBE-3715 Added logging
Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data_diff/databases/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ def normalize_struct(self, value: str, _coltype: Struct) -> str:
# match on both sides: i.e. have properly ordered keys, same spacing, same quotes, etc.
return f"to_json_string({value})"

def normalize_decimal(self, value: str, coltype: Decimal) -> str:
# Format DECIMAL/NUMERIC values as strings with 2 decimal places for consistent comparison
return f"FORMAT('%.2f', {value})"


@attrs.define(frozen=False, init=False, kw_only=True)
class BigQuery(Database):
Expand Down
3 changes: 3 additions & 0 deletions data_diff/hashdiff_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ def _diff_segments(
return

info_tree.info.is_diff = True
logger.info(
". " * level + f"Diffing segment results: count1/count2 {count1}/{count2} checksum1/checksum2 {checksum1}/{checksum2}"
)
return self._bisect_and_diff_segments(ti, table1, table2, info_tree, level=level, max_rows=max(count1, count2))

def _bisect_and_diff_segments(
Expand Down
Loading