Require map form for grid_pts in grid / python_grid scanners#589
Open
anderkve wants to merge 1 commit into
Open
Require map form for grid_pts in grid / python_grid scanners#589anderkve wants to merge 1 commit into
anderkve wants to merge 1 commit into
Conversation
grid_pts must now be a YAML map from "<model>::<param>" to integer. The list / scalar / 'parameters' override forms are gone, removing the silent dependence on the alphabetical sort of the shown parameter names. The example YAML files that use the grid scanner have been updated, and on rank 0 the scanner logs the resolved parameter -> grid points mapping at startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grid_pts must now be a YAML map from "::" to integer, removing the silent dependence on the alphabetical sort of the shown parameter names. The example YAML files that use the grid scanner have been updated, and on rank 0 the scanner logs the resolved parameter -> grid points mapping at startup.