💥 boom: replace Protocols with optype equivalents#75
Open
nstarman wants to merge 2 commits intoGalacticDynamics:mainfrom
Open
💥 boom: replace Protocols with optype equivalents#75nstarman wants to merge 2 commits intoGalacticDynamics:mainfrom
nstarman wants to merge 2 commits intoGalacticDynamics:mainfrom
Conversation
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
github-actions
bot
added
🔧 Add / update configuration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 97.36% 97.33% -0.04%
==========================================
Files 12 12
Lines 304 300 -4
==========================================
- Hits 296 292 -4
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the internal CanCopyReplace Protocol with the equivalent opt.copy.CanReplaceSelf from the optype library. This is a breaking change that removes a previously exported type from the public API.
Changes:
- Added
optype>=0.9.3as a new dependency with version-specific constraints (0.9.3 for Python <3.11, 0.15.0 for Python ≥3.11) - Removed the
CanCopyReplaceProtocol class and exported type from the codebase - Updated all usages of
CanCopyReplaceto useopt.copy.CanReplaceSelfinstead
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Added optype dependency with appropriate version constraints for different Python versions |
| pyproject.toml | Added optype>=0.9.3 to project dependencies |
| src/dataclassish/_src/types.py | Removed CanCopyReplace Protocol definition and export, removed now-unused Self import |
| src/dataclassish/_src/register_copyreplace.py | Updated to import and use opt.copy.CanReplaceSelf instead of local CanCopyReplace; updated docstring |
| src/dataclassish/init.py | Removed CanCopyReplace from public exports and imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.