feat(thaumcraft): Added new item ArcaneCraftingUpgrade

[hinyb]

This item was based on the initial work in the draft PR.
This PR completes and supersedes #155, which has been inactive for several months.
Add three functions: craft, craftNormal, craftArcane.

Closes #155

Credits Co-authored-by: @AX3Lino

[Nikolay-Sitnikov]

Does this run properly when Thaumcraft isn't installed?

[hinyb]

Does this run properly when Thaumcraft isn't installed?

Yes, it works fine without it.

[hinyb]

@UltraProdigy , It seems like that the optimize images workflow you recently added is currently failing on my PR, likely due to the bot lacking the permissions to access the repository. Could you please take a look at the workflow? Thanks!

[spacebuilder2020]

Does this run properly when Thaumcraft isn't installed?

Yes, it works fine without it.

Has this been tested when the Thaumcraft mod is not installed?
The reason this could be a potential issue is because there are direct references to the new thaumcraft driver in the main opencomputers mod class file. I am not fully familiar with how open computers work, but I would assume the integration is handled by the ModThaumcraft class, where the other drivers are located. I am concerned that if you attempt to load the driver directly from the main class it could cause a class not found exception when Thuamcraft is not installed since it won't be able to fully load the driver class.

https://github.com/GTNewHorizons/OpenComputers/pull/170/changes#diff-16e4f691e554cd85835d10fc813ff16749bb6b79f6673c272c881ac7560cbcc1R39

[hinyb]

Does this run properly when Thaumcraft isn't installed?

Yes, it works fine without it.

Has this been tested when the Thaumcraft mod is not installed? The reason this could be a potential issue is because there are direct references to the new thaumcraft driver in the main opencomputers mod class file. I am not fully familiar with how open computers work, but I would assume the integration is handled by the ModThaumcraft class, where the other drivers are located. I am concerned that if you attempt to load the driver directly from the main class it could cause a class not found exception when Thuamcraft is not installed since it won't be able to fully load the driver class.

https://github.com/GTNewHorizons/OpenComputers/pull/170/changes#diff-16e4f691e554cd85835d10fc813ff16749bb6b79f6673c272c881ac7560cbcc1R39

I've tested it without Thaumcraft and it works fine. Since the JVM uses lazy class loading, it won't trigger a NoClassDefFoundError because the item won't be created.
But you're right, I really shouldn't put the driver here. Sorry about my mistake.

[OvermindDL1]

Looked over the code and not seeing anything immediately wrong, looks fine overall, very large but that's expected for something like this, but it seems fine. Kept tracing through various call paths since some invariants aren't documented but that's on OC and not this PR for that, but it seems like everything I followed was upheld so it seems good.

[guneykabel]

Small minor cleanups

[Dream-Master]

@guneykabel can you re check this pr?

[guneykabel]

I found a few issues worth addressing most are small fixes. The one I'd call a real bug is the consumeAllVis early return being inverted. Left inline comments below this is a big pr and if possible I would like to hear some other thoughts as well