Skip to content

Add river-routing restart assembling#170

Merged
sdrabenh merged 7 commits intomainfrom
feature/wjiang/add_route_remap
Apr 15, 2026
Merged

Add river-routing restart assembling#170
sdrabenh merged 7 commits intomainfrom
feature/wjiang/add_route_remap

Conversation

@weiyuan-jiang
Copy link
Copy Markdown
Contributor

The river routing restart file will be created by combining an old restart and params from BC. There is no remapping since all are in catchment space

@weiyuan-jiang
Copy link
Copy Markdown
Contributor Author

@github-actions
Copy link
Copy Markdown

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

@gmao-rreichle gmao-rreichle changed the title Add river-routing restart assembeling Add river-routing restart assembling Apr 10, 2026
@gmao-rreichle gmao-rreichle added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Apr 10, 2026
@weiyuan-jiang
Copy link
Copy Markdown
Contributor Author

This line will be replaced when the location of the parameter file is in BCs https://github.com/GEOS-ESM/GEOS_Util/blob/48f8e327077e4f19c1e22b43dd9a9db80f481c42/pre/remap_restart/remap_other_restarts.py#L200C8-L200C115

changed

@gmao-rreichle gmao-rreichle marked this pull request as ready for review April 10, 2026 18:57
@gmao-rreichle gmao-rreichle requested review from a team as code owners April 10, 2026 18:57
gmao-rreichle
gmao-rreichle previously approved these changes Apr 10, 2026
bena-nasa
bena-nasa previously approved these changes Apr 10, 2026
@weiyuan-jiang weiyuan-jiang dismissed stale reviews from bena-nasa and gmao-rreichle via 83aad81 April 13, 2026 13:05
… -- the route_parameters.nc file used by remap_restarts has to come from the BCs, not from 'make_bcs_inputs' (remap_other_restarts.py)

This reverts commit 83aad81.
@sdrabenh sdrabenh merged commit d60191a into main Apr 15, 2026
17 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/add_route_remap branch April 15, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants