Skip to content

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented May 29, 2025

This PR:

See GEOS-DEV/GEOS#3697 for testing.

@bmhan12 bmhan12 self-assigned this May 29, 2025
@bmhan12 bmhan12 changed the title [WIP] Consolidate shared package versions for spack.yaml files refactor: Consolidate shared package versions for spack.yaml files Jun 12, 2025
@rrsettgast rrsettgast requested a review from Copilot September 18, 2025 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rrsettgast
Copy link
Member

@bmhan12 When we try to build the TPL's on LC we get the following error:

==> Removing install failure marks
==> Removing cached information on repositories
==> Removing python cache files
[creating spack env]
[exe: /usr/WS1/GEOS/GEOSX/TPLs_2025-09-18/dane-gcc-12_tpls/spack/bin/spack env create -d /usr/WS1/GEOS/GEOSX/TPLs_2025-09-18/dane-gcc-12_tpls/dane-gcc-12_env /usr/WS1/geosadmn/geosx/thirdPartyLibs/scripts/spack_configs/toss_4_x86_64_ib/spack.yaml]
==> Error: Detected 2 missing include path(s):
   /usr/WS1/GEOS/GEOSX/TPLs_2025-09-18/dane-gcc-12_tpls/versions.yaml
   /usr/WS1/GEOS/GEOSX/TPLs_2025-09-18/dane-gcc-12_tpls/defaults.yaml
[ERROR: Failed to create Spack Environment]

I think this means that the two new yaml files were not copied to the install directory. I.e. they are not present in /usr/WS1/GEOS/GEOSX/TPLs_2025-09-18/dane-gcc-12_tpls/dane-gcc-12_env

who should be responsible for copying these? I assume it is the same component that copies spack.yaml? And why do the CI jobs work ok?

@bmhan12
Copy link
Contributor Author

bmhan12 commented Sep 18, 2025

When we try to build the TPL's on LC we get the following error:

This PR does require an update to the uberenv submodule to use the versions and defaults.
Maybe that might be causing the issue?

@rrsettgast
Copy link
Member

@bmhan12 well...that is embarrassing

@rrsettgast rrsettgast merged commit 3cb43cc into master Sep 19, 2025
12 checks passed
@bmhan12 bmhan12 deleted the feature/han12/less_dup branch December 4, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants