Skip to content

Update RAJA suite to v2025.03.0 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rrsettgast merged 7 commits into from
Apr 14, 2025
Merged

Update RAJA suite to v2025.03.0 #303

rrsettgast merged 7 commits into from
Apr 14, 2025

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Mar 20, 2025 •
edited
Loading

This PR:

  • Updates the RAJA suite of packages to v2025.03.0
  • Modifies host-config generation logic so cuda version is part of host-config name (avoids naming collision between clang@13 cuda@11 and clang@13 cuda@12 )
  • Modifies LC spack script setupLC-TPL-uberenv-helper.bash to remove extra build files on successful completion to avoid hitting directory size limit.

GEOS-DEV/GEOS#3613
GEOS-DEV/LvArray#347

@bmhan12 bmhan12 self-assigned this Mar 20, 2025
@bmhan12 bmhan12 force-pushed the feature/han12/raja_3_25 branch from 38b9aa1 to 66517d9 Compare March 27, 2025 15:10
@bmhan12 bmhan12 mentioned this pull request Mar 27, 2025
Merged
CusiniM
CusiniM reviewed Apr 7, 2025
View reviewed changes
scripts/spack_configs/blueos_3_ppc64le_ib_p9/spack.yaml
require: "@git.1ed0669c57f041baa1f1070693991c3a7a43e7ee=develop"

# v2024.07.0
# v2025.0.3.0
Copy link
Contributor

@CusiniM CusiniM Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we specify this in the geos package instead of specifying a commit hash here? seems easier and does not require duplication.

Copy link
Contributor Author

@bmhan12 bmhan12 Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we specify this in the geos package instead of specifying a commit hash here? seems easier and does not require duplication

As of a few days ago, yes: https://github.com/spack/spack/blame/8885f6b861ea8721711ad7d9030593968a62e959/var/spack/repos/builtin/packages/raja/package.py#L34-L39

Before that spack commit, v2025.03.0 was not in spack yet, so I went with the commit hash.

However, this involves updating our spack version to a newer commit, which may cause other issues.
I think it makes sense to get the v2025.03.0 changes in this PR in first, then do the refactoring and spack version bump in #305.

Copy link
Contributor

@CusiniM CusiniM Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

@bmhan12 bmhan12 mentioned this pull request Apr 8, 2025
Merged
@bmhan12 bmhan12 changed the title [WIP] Update RAJA suite to v2025.03.0 Update RAJA suite to v2025.03.0 Apr 10, 2025
@rrsettgast rrsettgast merged commit 6316d0b into master Apr 14, 2025
12 checks passed
@bmhan12 bmhan12 deleted the feature/han12/raja_3_25 branch December 4, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrsettgast rrsettgast rrsettgast approved these changes

@CusiniM CusiniM CusiniM approved these changes

Assignees

@bmhan12 bmhan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmhan12 @rrsettgast @CusiniM