refactor: Use an enum to deal with the piece of attributes and not bool #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainBaville
added
test-geos-integration
RomainBaville
requested review from
alexbenedicto,
jafranc and
paloma-martinez
jafranc
approved these changes
Dec 23, 2025
Collaborator
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
Great work !! Should be push further in meshdoctor in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the way of dealing with the piece of an attribute.
Instead of using a bool with True for points attributes and False for cells attributes, the idears is to use an enum to manage more precisely the piece inforamtion of an attribute: