fix: Fix and refactor Timeline component in trame #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paloma-martinez
approved these changes
Dec 16, 2025
Comment on lines
+51
to
+56
| #use to refect change in simput to gantt | ||
| # def _on_change( topic: str, ids: list | None = None ) -> None: | ||
| # if ids is not None and topic == "changed": | ||
| # print("blablabla") | ||
|
|
||
| # self.simput_manager.proxymanager.on( _on_change ) |
Collaborator
Author
There was a problem hiding this comment.
Yes exactly.
This is a paved way for including from formulaire to gantt reactivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at making a workable Timeline component in trame UI that will:
Re-think the timeline peek view (to something clearer)