fix: Correct Read The Docs build failures #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paloma-martinez
approved these changes
Jul 25, 2025
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
Thank you for the fix !
Do you have an idea of what we could add to the CI to prevent this kind of problem ? It seems a lot of PR CI docs checks were valid while the actual buildings of the doc failed..
RomainBaville
approved these changes
Jul 25, 2025
Collaborator
Author
|
@paloma-martinez I updated the doc-test.yml to be matching the .readthedocs.yaml build so the CI should fail correctly now if the same issue occurs. |
alexbenedicto
deleted the
benedicto/fix/correct_read_the_docs_build_failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114
This PR aims to correct the failures in the latest Read The Docs builds.
Specific packages when installing docs/requirements.txt caused conflicts because the python version used is 3.10.
The first solution was to upgrade to python 3.11 but this would not respect the supported versions 3.10 to 3.12 in the repository.
The second solution now applied in this PR is to restrict the version of specific packages.
PS:
The first build that failed was after modifying these packages in the following commit de62e29 (see image):