Open
Conversation
dkachuma
added
type: bug
bd713
approved these changes
Apr 10, 2026
Contributor
bd713
left a comment
bd713
left a comment
There was a problem hiding this comment.
Thanks for fixing it. I confirm that the test now passes
rrsettgast
reviewed
Apr 11, 2026
Comment on lines
+294
to
+297
| if( phaseStepSize < 1.0 ) | ||
| { | ||
| phaseStepSize *= (1.0 - STEP_TOLERANCE); | ||
| } |
Member
There was a problem hiding this comment.
So if the phaseStepSize is less than 1.0, you are reducing by a small factor? Can you expand on how this helps?
Contributor
Author
There was a problem hiding this comment.
The phaseStepSize is less than 1 if we don't want to go outside the bounds of the capillary pressure curve. Reducing it further ensures that we are truly away from the boundary. In some cases we were ending up on the boundary itself. If evaluated at the boundary, some of the capillary pressure curves give a zero derivative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the inverse capillary pressure calculation for 3-phase cases where the oil phase disappears. A correction factor is applied to the Newton step to ensure that we do not evaluate the capillary pressure curves outside their bounds.