fix: balance compilation time and memory usage for MFD kernels#4026
Merged
castelletto1 merged 3 commits intodevelopfrom Apr 11, 2026
Merged
Conversation
OmarDuran
requested review from
dkachuma,
rrsettgast and
tjb-ltk
as code owners
…ry_polyehdral_kernels
OmarDuran
added
ci: run CUDA builds
dkachuma
approved these changes
Apr 10, 2026
castelletto1
approved these changes
Apr 11, 2026
castelletto1
deleted the
fix/oduran/balanced_compilation_time_memory_polyehdral_kernels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is addressing issue-3894 by refactoring the CMake-generated kernel dispatch for MFD discretizations.
The previous CMake-generated dispatch created a single translation unit per generated type. While this approach minimized memory usage during compilation, it resulted in longer compilation times. An attempt was made to address this by creating a single translation unit containing all possible types; however, this approach is also suboptimal, as it reduces compilation time at the cost of excessive memory usage.
The current refactor proposes a solution between these two extremes by grouping translation units according to the number of faces of the intended polyhedral cell. This approach moderates memory consumption while keeping compilation times practical for developers.
Fixes #3894