Skip to content

fix: thermal prod well inflow der #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjb-ltk wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix: thermal prod well inflow der #4024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e3f67cf
thermal prod well inflow der fix
tjb-ltk Apr 9, 2026
9b52bfd
uncrust
tjb-ltk Apr 9, 2026
c7f9415
activate more unit tests, fix for case where there is 2 phase injecti…
tjb-ltk Apr 10, 2026
61f750e
cleanup inflow ders
tjb-ltk Apr 14, 2026
e92e4c2
Merge branch 'develop' into fix/byer3/thermalWell
tjb-ltk Apr 14, 2026
4c8645f
use correct density for upstream inflow calc
tjb-ltk Apr 15, 2026
4cd881b
clarify and fix test
tjb-ltk Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreComponents/integrationTests/wellsTests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ if( ENABLE_PVTPackage )
testReservoirThermalSinglePhaseMSWells_RateInj.cpp
testIsothermalReservoirCompositionalMultiphaseMSWells.cpp
testIsothermalReservoirCompositionalMultiphaseSSWells.cpp
testThermalInjWell.cpp
testThermalProdWell.cpp
testThermalReservoirCompositionalMultiphaseSSWells.cpp
testThermalReservoirCompositionalMultiphaseMSWells.cpp )
endif()
Expand Down
10 changes: 9 additions & 1 deletion src/coreComponents/integrationTests/wellsTests/testReservoirThermalSinglePhaseMSWells.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,12 @@ void testNumericalJacobian( SinglePhaseReservoirAndWells<> & solver,

domain.forMeshBodies( [&] ( MeshBody & meshBody )
{
bool processMesh = true;
meshBody.forMeshLevels( [&] ( MeshLevel & mesh )
{
if( !processMesh )
return;
processMesh = false;
ElementRegionManager & elemManager = mesh.getElemManager();

for( localIndex er = 0; er < elemManager.numRegions(); ++er )
Expand Down Expand Up @@ -349,7 +353,7 @@ void testNumericalJacobian( SinglePhaseReservoirAndWells<> & solver,

fillNumericalJacobian( residual.toViewConst(),
residualOrig.toViewConst(),
dofNumber[ei],
dofNumber[ei]+1,
dT,
jacobianFD.toViewConstSizes() );
}
Expand Down Expand Up @@ -528,6 +532,10 @@ class SinglePhaseReservoirSolverTest : public ::testing::Test
[&] ( CRSMatrixView< real64, globalIndex const > const & localMatrix,
arrayView1d< real64 > const & localRhs )
{
// commented out due to treatement of temp well constraint. This is the only term that is causing the test to fail, and the test is
// good otherwise. If this is fixed, uncomment out printCompareLocalMatrices and look at FD and computed derivatives
// uncomment out printCompareLocalMatrices and look at FD and computed derivatives
// solver->wellSolver()->assembleSystem( TIME, DT, domain, solver->getDofManager(), localMatrix, localRhs );
solver->assembleCouplingTerms( TIME, DT, domain, solver->getDofManager(), localMatrix, localRhs );
} );
}
Expand Down
7 changes: 6 additions & 1 deletion ...Components/integrationTests/wellsTests/testReservoirThermalSinglePhaseMSWells_RateInj.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,12 @@ void testNumericalJacobian( SinglePhaseReservoirAndWells<> & solver,

domain.forMeshBodies( [&] ( MeshBody & meshBody )
{
bool processMesh = true;
meshBody.forMeshLevels( [&] ( MeshLevel & mesh )
{
if( !processMesh )
return;
processMesh = false;
ElementRegionManager & elemManager = mesh.getElemManager();

for( localIndex er = 0; er < elemManager.numRegions(); ++er )
Expand Down Expand Up @@ -606,10 +610,11 @@ class SinglePhaseReservoirSolverTest : public ::testing::Test

DomainPartition & domain = state.getProblemManager().getDomainPartition();

testNumericalJacobian( *solver, domain, perturb, tol, false, __func__,
testNumericalJacobian( *solver, domain, perturb, tol, true, __func__,
[&] ( CRSMatrixView< real64, globalIndex const > const & localMatrix,
arrayView1d< real64 > const & localRhs )
{
solver->wellSolver()->assembleSystem( TIME, DT, domain, solver->getDofManager(), localMatrix, localRhs );
solver->assembleCouplingTerms( TIME, DT, domain, solver->getDofManager(), localMatrix, localRhs );
} );
}
Expand Down
Loading
Loading