feat: Add Young Modulus & Poisson import from VTK mesh#4021
Open
npillardou wants to merge 10 commits intodevelopfrom
Open
feat: Add Young Modulus & Poisson import from VTK mesh#4021npillardou wants to merge 10 commits intodevelopfrom
npillardou wants to merge 10 commits intodevelopfrom
Conversation
jhuang2601
approved these changes
Apr 10, 2026
| continue; | ||
|
|
||
| // E was imported and is positive: nu must also be valid | ||
| GEOS_ERROR_IF( nu[k] <= -0.5 || nu[k] >= 0.5, |
Contributor
There was a problem hiding this comment.
For most common materials, Poisson’s ratio falls within the range of 0 to 0.5.
Contributor
Author
There was a problem hiding this comment.
I agree with you, but there was some checks already done around line 80-84 that were with this range :
if( nu > -0.5 && nu < 0.5 )
{
++numConstantsSpecified;
errorCheck += "nu, ";
}
So I kept them as it is.
dkachuma
approved these changes
Apr 10, 2026
Contributor
dkachuma
left a comment
There was a problem hiding this comment.
My understanding of (nu, E, K and G) is that we need only 2 of these. What combinations are currently supported. Currently you can provide K and G. You're proposing nu and E I suppose, but can we do any other combinations. Maybe just add a note in the documentation. For example what happens if the user tries to load K and E?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds register data fields for Poisson's ratio and Young Modulus directly from VTK mesh, avoiding any external conversion operations.
It also offers the possibility to obtain them as output by adding (according to user needs) :
<Outputs> <VTK name="vtkOutput" fieldNames="{ rock_youngModulus, rock_poissonRatio }" /> </Outputs>