-
Notifications
You must be signed in to change notification settings - Fork 101
feat: Add reference thermal conductivity #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkachuma
wants to merge
28
commits into
develop
Choose a base branch
from
dkachuma/reference-thermal-conductivity
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
07da0dc
feat: Add reference thermal conductivity
dkachuma 66fc294
Update reference temperature
dkachuma 0c3212e
Fix ats file
dkachuma ebe53a0
Rebaseline
dkachuma 88e907d
Capture local variable for kernel launch
dkachuma b8e7357
Update schema
dkachuma 1946e48
Initialise thermal conductivity
dkachuma c1c238d
Fix CUDA compilation error
dkachuma 7e6ed1e
Add thermal conductivity to embedded fracture solver
dkachuma 1e1f2c0
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma b260905
Rebaseline
dkachuma 8513525
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma b89d2a5
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma f29ff61
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma 0e69780
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma ab42f1d
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma 0e26b5b
Restore baseline notes
dkachuma b881d54
Rebaseline
dkachuma 77e542a
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma d2f92f2
Update baseline path in integrated tests configuration
dkachuma 19e5288
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma d4852dc
Rebaseline
dkachuma 809c0ef
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma 7a8e07f
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma 2cdc31e
Rebaseline
dkachuma 901fe5b
Merge branch 'develop' into dkachuma/reference-thermal-conductivity
dkachuma c2da3eb
Rebaseline
dkachuma b9a4e48
Merge origin/develop into dkachuma/reference-thermal-conductivity
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| mesh_1d.vtr filter=lfs diff=lfs merge=lfs -text |
Git LFS file not shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
206 changes: 206 additions & 0 deletions
206
inputFiles/singlePhaseWell/thermal_compressible_single_phase_wells_1d.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,206 @@ | ||
| <?xml version="1.0"?> | ||
| <Problem> | ||
| <Solvers> | ||
| <SinglePhaseReservoir | ||
| name="RESERVOIR.SOLVER" | ||
| flowSolverName="FLOW.SOLVER" | ||
| wellSolverName="WELL.SOLVER" | ||
| logLevel="1" | ||
| initialDt="86400" | ||
| targetRegions="{ RESERVOIR, WELL }"> | ||
| <NonlinearSolverParameters | ||
| newtonTol="1.0e-4" | ||
| maxAllowedResidualNorm="1e12" | ||
| newtonMaxIter="25" /> | ||
| <LinearSolverParameters | ||
| solverType="fgmres" | ||
| preconditionerType="mgr" | ||
| krylovTol="1e-4" | ||
| krylovAdaptiveTol="1" | ||
| krylovWeakestTol="1e-4" | ||
| logLevel="1" /> | ||
| </SinglePhaseReservoir> | ||
|
|
||
| <SinglePhaseFVM | ||
| name="FLOW.SOLVER" | ||
| discretization="FLUID.TPFA" | ||
| targetRegions="{ RESERVOIR }" | ||
| temperature="380.15" | ||
| isThermal="1" | ||
| logLevel="2" /> | ||
| <SinglePhaseWell | ||
| name="WELL.SOLVER" | ||
| logLevel="1" | ||
| isThermal="1" | ||
| targetRegions="{ WELL }"> | ||
| <WellControls | ||
| name="WELL.CONTROL" | ||
| type="injector" | ||
| control="totalVolRate" | ||
| referenceElevation="-200" | ||
| useSurfaceConditions="1" | ||
| surfacePressure="101325.0" | ||
| surfaceTemperature="283.15" | ||
| injectionTemperature="293.15" | ||
| initialPressureCoefficient="0" | ||
| injectionStream="{1.0}" | ||
| targetBHP="1e10" | ||
| enableCrossflow="0" | ||
| targetTotalRateTableName="RATE" /> | ||
| </SinglePhaseWell> | ||
| </Solvers> | ||
|
|
||
| <NumericalMethods> | ||
| <FiniteVolume> | ||
| <TwoPointFluxApproximation | ||
| name="FLUID.TPFA" /> | ||
| </FiniteVolume> | ||
| </NumericalMethods> | ||
|
|
||
| <Mesh> | ||
| <VTKMesh | ||
| name="GLOBAL" | ||
| file="mesh_1d.vtr" | ||
| fieldNamesInGEOS="{ THERMAL.COND_referenceThermalConductivity }" | ||
| fieldsToImport="{ CONDUCTIVITY }" | ||
| logLevel="5"> | ||
| <InternalWell | ||
| name="well.INJECTOR" | ||
| wellRegionName="WELL" | ||
| wellControlsName="WELL.CONTROL" | ||
| polylineNodeCoords="{ | ||
| { 6440.37, 0.0, -200 }, | ||
| { 6440.37, 0.0, -300 } | ||
| }" | ||
| polylineSegmentConn="{ { 0, 1 } }" | ||
| radius="0.19" | ||
| numElementsPerSegment="1"> | ||
| <Perforation | ||
| name="WELL.PERF.1" | ||
| distanceFromHead="75.0" /> | ||
| </InternalWell> | ||
| </VTKMesh> | ||
| </Mesh> | ||
|
|
||
| <ElementRegions> | ||
| <CellElementRegion | ||
| name="RESERVOIR" | ||
| cellBlocks="{ hexahedra }" | ||
| materialList="{ FLUID, ROCK, THERMAL.COND }" /> | ||
| <WellElementRegion | ||
| name="WELL" materialList="{ FLUID }" /> | ||
| </ElementRegions> | ||
|
|
||
| <Constitutive> | ||
| <ThermalCompressibleSinglePhaseFluid | ||
| name="FLUID" | ||
| defaultDensity="1032.26544679" | ||
| defaultViscosity="0.0002634" | ||
| referencePressure="40810068.4183" | ||
| referenceDensity="1032.26544679" | ||
| compressibility="0.00037130e-5" | ||
| referenceViscosity="0.0002634" | ||
| referenceTemperature="380.15" | ||
| thermalExpansionCoeff="3e-4" | ||
| viscosibility="0.0" | ||
| specificHeatCapacity="4180.0" | ||
| referenceInternalEnergy="0.001" /> | ||
|
|
||
| <NullModel | ||
| name="NULL.SOLID" /> | ||
|
|
||
| <SinglePhaseThermalConductivity | ||
| name="THERMAL.COND" | ||
| defaultThermalConductivityComponents="{ 0.68337, 0.68337, 0.68337 }" | ||
| thermalConductivityGradientComponents="{ -1.2e-5, -1.2e-5, -1.5e-5 }" | ||
| referenceTemperature="380.15" /> | ||
|
|
||
| <SolidInternalEnergy | ||
| name="ROCK.ENERGY" | ||
| referenceVolumetricHeatCapacity="2.07e6" | ||
| referenceTemperature="273.0" | ||
| referenceInternalEnergy="0.0" /> | ||
|
|
||
| <CompressibleSolidConstantPermeability | ||
| name="ROCK" | ||
| solidModelName="NULL.SOLID" | ||
| porosityModelName="ROCK.POROSITY" | ||
| permeabilityModelName="ROCK.PERMEABILITY" | ||
| solidInternalEnergyModelName="ROCK.ENERGY" /> | ||
|
|
||
| <PressurePorosity | ||
| name="ROCK.POROSITY" | ||
| defaultReferencePorosity="0.3" | ||
| referencePressure="40800000.0000" | ||
| compressibility="4.0950e-14" /> | ||
|
|
||
| <ConstantPermeability | ||
| name="ROCK.PERMEABILITY" | ||
| permeabilityComponents="{ 9.869233e-14, 9.869233e-14, 9.869233e-14}" /> | ||
|
|
||
| </Constitutive> | ||
|
|
||
| <FieldSpecifications> | ||
| <FieldSpecification | ||
| name="INITIAL.PRESSURE" | ||
| setNames="{ all }" | ||
| objectPath="ElementRegions/RESERVOIR" | ||
| fieldName="pressure" | ||
| scale="169.12e5" | ||
| initialCondition="1" /> | ||
| <FieldSpecification | ||
| name="INITIAL.TEMPERATURE" | ||
| setNames="{ all }" | ||
| objectPath="ElementRegions/RESERVOIR" | ||
| fieldName="temperature" | ||
| scale="380.15" | ||
| initialCondition="1" /> | ||
| </FieldSpecifications> | ||
|
|
||
| <Functions> | ||
| <TableFunction | ||
| name="RATE" | ||
| interpolation="lower" | ||
| inputVarNames="{ time }" | ||
| coordinates="{ 0.0, 2592000, 86400000}" | ||
| values="{ 0.0, 2.911949431, 2.911949431 }" /> | ||
|
|
||
| </Functions> | ||
|
|
||
| <Tasks> | ||
| <SinglePhaseStatistics | ||
| name="STATISTICS" | ||
| flowSolverName="FLOW.SOLVER" | ||
| logLevel="1" | ||
| writeCSV="1" /> | ||
| </Tasks> | ||
|
|
||
| <Outputs> | ||
| <VTK | ||
| name="VTK" /> | ||
| <Restart | ||
| name="RESTART"/> | ||
| </Outputs> | ||
|
|
||
| <Events maxTime="9504000"> | ||
| <PeriodicEvent | ||
| name="SOLVER.APPLICATION" | ||
| target="/Solvers/RESERVOIR.SOLVER" | ||
| maxEventDt="864000" /> | ||
| <PeriodicEvent | ||
| name="STATISTICS" | ||
| target="/Tasks/STATISTICS" | ||
| targetExactTimestep="1" | ||
| timeFrequency="864000" /> | ||
| <PeriodicEvent | ||
| name="VTK" | ||
| target="/Outputs/VTK" | ||
| targetExactTimestep="1" | ||
| timeFrequency="864000" /> | ||
| <PeriodicEvent | ||
| name="RESTART" | ||
| timeFrequency="1728000" | ||
| targetExactTimestep="1" | ||
| target="/Outputs/RESTART" /> | ||
| </Events> | ||
| </Problem> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -46,21 +46,35 @@ SinglePhaseThermalConductivity::SinglePhaseThermalConductivity( string const & n | |||||||||||||||||||||||||||||||
| setDescription( "The reference temperature at which the conductivity components are equal to the default values" ); | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| void SinglePhaseThermalConductivity::allocateConstitutiveData( Group & parent, localIndex const numPts ) | ||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| SinglePhaseThermalConductivityBase::allocateConstitutiveData( parent, numPts ); | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| initializeState( parent.size()); | ||||||||||||||||||||||||||||||||
|
Comment on lines
+52
to
+53
|
||||||||||||||||||||||||||||||||
| initializeState( parent.size()); |
Comment on lines
+141
to
+143
Copilot
AI
Apr 14, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initializeState(size) currently overwrites referenceThermalConductivity for every element (no guard). Since SurfaceGenerator/EmbeddedSurfaceGenerator call initializeState() after creating fracture elements, this can clobber previously imported or previously set values. Consider only initializing entries that are still unset (e.g., <= 0, similar to ConstantPermeability::initializeState()), and/or initializing only the newly-added element range.
Suggested change
| referenceThermalConductivity[ei][q][0] = defaultThermalConductivityComponents[0]; | |
| referenceThermalConductivity[ei][q][1] = defaultThermalConductivityComponents[1]; | |
| referenceThermalConductivity[ei][q][2] = defaultThermalConductivityComponents[2]; | |
| if( referenceThermalConductivity[ei][q][0] <= 0 ) | |
| { | |
| referenceThermalConductivity[ei][q][0] = defaultThermalConductivityComponents[0]; | |
| } | |
| if( referenceThermalConductivity[ei][q][1] <= 0 ) | |
| { | |
| referenceThermalConductivity[ei][q][1] = defaultThermalConductivityComponents[1]; | |
| } | |
| if( referenceThermalConductivity[ei][q][2] <= 0 ) | |
| { | |
| referenceThermalConductivity[ei][q][2] = defaultThermalConductivityComponents[2]; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar in the test description: "1 wells" should be singular ("1 well").