Skip to content

feat: Error reporting at the end of the simulatiuon #3929

Open
arng40 wants to merge 354 commits intofeat/dudes/perforations-table-detailfrom
feat/dudes/warning-report
Open

feat: Error reporting at the end of the simulatiuon #3929
arng40 wants to merge 354 commits intofeat/dudes/perforations-table-detailfrom
feat/dudes/warning-report

Conversation

@arng40
Copy link
Copy Markdown
Contributor

@arng40 arng40 commented Dec 23, 2025 •
edited
Loading

Will be merged after : #3902

  • Introduce a logHistory to store all the log
  • Gathering logs between ranks

Located after MemoryStatsOutput :

Ex :

Types Error ExternalError Warning Exception
MeshGeneration 0 0 3 0
NumericalMethods 0 0 5 0
ImportFields 0 0 5 0

MelReyCG and others added 30 commits September 19, 2025 16:21
@MelReyCG
♻️ ✅ uniformized warning macros
66ab5cb
@MelReyCG
✅ 🐛 ⚡️ bugfix when callstack is empty + disable callstack for perfs
e6135b1
@MelReyCG
♻️ ✅ uniformized throw macros
589fcfe
@MelReyCG
✅ removing _CTX macros from unit test
6fc4b30
@MelReyCG
🐛 use streamed cause string to support mpi pointers formatting (not s…
77f9fcb 
…upported by fmt for now)
@MelReyCG
🐛 last mistake?
5747e7f
@MelReyCG
♻️ removing all GEOS_*_CTX macros (as GEOS_ERROR, GEOS_WARNING, GEOS_…
10eb969 
…ASSERT and GEOS_THROW are now compatible with context parameters)
@MelReyCG
🎨 UNCRUSTIFY
2c5c5f5
@MelReyCG
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
d1642e6 
…y/create-yaml-file-and-structure
@MelReyCG
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
b3cbb99 
…y/create-yaml-file-and-structure
@MelReyCG
✨ allowing to re-throw with GEOS_THROW* macros
5781a78
@MelReyCG
📦 shema
db75e45
@MelReyCG
♻️ removing unintended BASE::
e07ab72
@arng40
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
754ed03 
…or-context
@arng40
xsd
83d0c0f
@arng40
Merge remote-tracking branch 'origin/feature/amandinehry/create-yaml-…
d5d8615 
…file-and-structure-2' into refactor/dudes/error-context
@MelReyCG
🎨 uncrustify
1913059
@MelReyCG
🐛 fix stream reset
6692dd2
@MelReyCG
⚰️ unused variable
29f6fbe
@MelReyCG
✨ removing last LVARRAY_* error logging macros
d17972f
@MelReyCG
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
759e9bb 
…y/create-yaml-file-and-structure-2
@MelReyCG
✨ removing last LVARRAY_* error logging macros
1b755b5
@MelReyCG
✅ adapting test with error cause addition
3786db4
@MelReyCG
🐛 GPU Macros Support
efa89d8
@MelReyCG
🎨 uncrustify
7915205
@MelReyCG
Merge branch 'develop' into feature/amandinehry/create-yaml-file-and-…
14eefee 
…structure-2
@MelReyCG
🐛 GPU forgotten instruction
500bbfd
@MelReyCG
🐛 added pragmas to manual shadow global logger instance
fa8fa54
@MelReyCG
Merge branch 'feature/amandinehry/create-yaml-file-and-structure-2' of …
a29510b 
…https://github.com/GEOS-DEV/GEOS into feature/amandinehry/create-yaml-file-and-structure-2
@MelReyCG
🐛 wrong conversion on GPU
c501a0f
@MelReyCG MelReyCG self-requested a review March 27, 2026 16:09
arng40 added 4 commits March 31, 2026 10:56
@arng40
♻️ refactor llog record serialize
cf1eb6d
@arng40
Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…
7b85e8c 
…-report
@arng40
🏷️ update serial type
b6a3658
@arng40
Squashed commit of the following:
79f9e90 
commit b962b2c
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Mar 31 10:52:52 2026 +0200

    :coffin: dead code & spaces

commit dfe0619
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Mar 31 10:51:32 2026 +0200

    :art: format code

commit 55aff05
Merge: ee7d7da ba863d7
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Mar 31 10:51:05 2026 +0200

    Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail

commit ee7d7da
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Mar 31 10:50:50 2026 +0200

    :bug: local scope for globalWellElemIndices

commit ba863d7
Merge: 0d22428 510dc76
Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
Date:   Tue Mar 31 10:34:16 2026 +0200

    Merge branch 'develop' into feat/dudes/perforations-table-detail

commit 0d22428
Merge: 17538bd 23a5694
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 18:01:56 2026 +0200

    Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail

commit 17538bd
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 18:01:44 2026 +0200

    :recycle: relocated in perfo data + renaming

commit 23a5694
Merge: 1181253 acd7cc5
Author: MelReyCG <122801580+MelReyCG@users.noreply.github.com>
Date:   Mon Mar 30 17:12:21 2026 +0200

    Merge branch 'develop' into feat/dudes/perforations-table-detail

commit 1181253
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 17:11:47 2026 +0200

    :art: added boolean array for perfo availibility

commit a302088
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Mar 30 11:19:58 2026 +0200

    🎨 spaces

commit 935d117
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 10:12:28 2026 +0200

    :art: improve testMpiTable Cond

commit 7d6249d
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 10:12:03 2026 +0200

    :art: update perdoration sorting cond

commit 81a96b2
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Mar 30 10:10:21 2026 +0200

    :coffin:  :label: remove dead code, update types

commit bdc15ec
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Mar 27 17:12:37 2026 +0100

    :truck: move declaration outside hpp

commit ecef467
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Mar 27 11:15:41 2026 +0100

    :green_heart: fix CI build
@MelReyCG MelReyCG changed the base branch from develop to feat/dudes/perforations-table-detail March 31, 2026 12:41
MelReyCG
MelReyCG reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lacks a unit-test

Comment thread src/coreComponents/common/logger/ErrorHandling.hpp Outdated
Comment thread src/coreComponents/common/logger/LogHistory.hpp Outdated
Comment thread src/coreComponents/common/logger/LogHistory.cpp Outdated
Comment thread src/coreComponents/common/logger/LogHistory.hpp Outdated
MelReyCG
MelReyCG reviewed Mar 31, 2026
View reviewed changes
Comment thread src/coreComponents/common/logger/LogHistory.hpp
@MelReyCG MelReyCG added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI and removed DO NOT MERGE ! labels Apr 7, 2026
@MelReyCG MelReyCG requested review from bd713 and jafranc as code owners April 7, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MelReyCG MelReyCG MelReyCG approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@victorapm victorapm Awaiting requested review from victorapm victorapm is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk

@herve-gross herve-gross Awaiting requested review from herve-gross

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601

@frankfeifan frankfeifan Awaiting requested review from frankfeifan

@jafranc jafranc Awaiting requested review from jafranc jafranc is a code owner

@bd713 bd713 Awaiting requested review from bd713 bd713 is a code owner

Assignees

@arng40 arng40

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arng40 @MelReyCG