feat: MultiPhase Poromechanics Conforming Fractures (ALM) #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuang2601
added
type: feature
jhuang2601
requested review from
CusiniM,
Guotong-Ren,
castelletto1,
frankfeifan,
paveltomin and
rrsettgast
as code owners
herve-gross
approved these changes
Dec 19, 2025
jafranc
approved these changes
Dec 22, 2025
Contributor
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
Looks good to me !! Thanks @jhuang2601
Comment on lines
+117
to
+118
| static const localIndex m_maxFaceNodes=11; // Maximum number of nodes on a contact face | ||
|
|
Contributor
There was a problem hiding this comment.
Should somehow be set in a parent class instead of hard-copied from implementation to implementation
Contributor
|
Maybe a quick test will add to CI strength |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR couples the ALM solver with multiphase flow in sequential mode