Add DeprecatedGroup and ObsoleteGroup implementations with unit tests #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrtobin
requested review from
CusiniM,
MelReyCG,
OmarDuran,
castelletto1,
corbett5,
dkachuma,
herve-gross,
jhuang2601,
paveltomin and
rrsettgast
as code owners
MelReyCG
reviewed
Dec 11, 2025
Comment on lines
+146
to
+153
| GEOS_LOG_RANK_0( GEOS_FMT( | ||
| "\n" | ||
| "********************************************************************************\n" | ||
| "* DEPRECATION WARNING\n" | ||
| "* Group: {}\n" | ||
| "* {}\n" | ||
| "********************************************************************************", | ||
| className, message ) ); |
Contributor
There was a problem hiding this comment.
Why not using a true GEOS_WARNING?
Comment on lines
+442
to
+451
| GEOS_LOG_RANK_0( GEOS_FMT( | ||
| "\n" | ||
| "********************************************************************************\n" | ||
| "* OBSOLETE GROUP WARNING\n" | ||
| "* Group: {}\n" | ||
| "* {}\n" | ||
| "* This group has been removed and will cause an error if used.\n" | ||
| "* (Group object created for input parsing compatibility only)\n" | ||
| "********************************************************************************", | ||
| className, message ) ); |
Contributor
There was a problem hiding this comment.
Same remark, why not GEOS_WARNING?
| * @tparam T The type that would normally be wrapped | ||
| */ | ||
| template< typename T > | ||
| class NoopWrapper final : public WrapperBase |
Contributor
There was a problem hiding this comment.
As metadata function as another wrapper, could it be used to document some aspects of a given Group?
If yes, it would be cool to have this class in its own file :)
If not, maybe it should be named after its final role (i.e. DeprecatedWrapper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting this up for review for the moment, not married to any design decisions and I assume we'll want to change output message structure.
This basically just introduces mechanisms to lifecycle internal types that have been replaced/supplanted while informing the user in obvious ways and maintaining the schema generation/documentation and parse>init process for that type until it drops completely from the project.
To deprecate any
Groupsubclass just, for e.g.class Foo : public ExecutableGroup(inherits from any group subclass):It basically just injects itself into the inheritance hierarchy and adds the deprecation/obsolescence behavior.