Skip to content

Conversation

@dkachuma
Copy link
Contributor

@dkachuma dkachuma commented May 13, 2025

This PR updates the CO2 injection example to address the issues raised in #3660

The pvt files in this case were updated at #2933. However, the update to the co2flash.txt file was missed. I have therefore updated the example so that the actual files are referenced directly without having to duplicate them in the rst.

The update at #2933 changed the ranges of pressure and temperature used to generate the PVT tables. These new values are more correct because they include the surface conditions required by the well. I cannot go back to the old ranges because now geos has a check to ensure that the well operates within the range of the PVT data.

According to the change at #2933, and also at #1065, I suspect the original images were generated with a temperature range that was too low. This led to the gas density being higher and therefore the gas not being as buoyant. When this was corrected, the gas became more buoyant as can be seen with the new results.

I have edited the case to make the images look a bit more like the original. I have halved the vertical permeability to curtail the gas migration upwards and reduced the porosity to 0.05 to ensure that the gas reaches the surface. The updated example has the new updated images.

@dkachuma dkachuma self-assigned this May 13, 2025
@dkachuma dkachuma changed the title doc: Update CO2 injection example docs: Update CO2 injection example May 13, 2025
@dkachuma dkachuma added type: documentation flag: requires rebaseline Requires rebaseline branch in integratedTests labels May 13, 2025
@dkachuma dkachuma marked this pull request as ready for review May 13, 2025 16:21
@dkachuma dkachuma added ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs labels May 13, 2025
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.43%. Comparing base (bbecb28) to head (b9a2168).
⚠️ Report is 62 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3661      +/-   ##
===========================================
- Coverage    57.57%   57.43%   -0.15%     
===========================================
  Files         1235     1234       -1     
  Lines       107102   106983     -119     
===========================================
- Hits         61669    61444     -225     
- Misses       45433    45539     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkachuma dkachuma removed the flag: requires rebaseline Requires rebaseline branch in integratedTests label May 14, 2025
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkachuma Thanks for updating this case.
@margauxraguenel Please take a look on this fix.

Copy link

@margauxraguenel margauxraguenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on our side, perfect!

@paveltomin paveltomin merged commit 91d2055 into develop May 28, 2025
27 of 28 checks passed
@paveltomin paveltomin deleted the dkachuma/doc/fix-co2-injection-example branch May 28, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI type: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tutorial Example for CO2 injection where the plume is different between the tutorial and the files to be loaded

8 participants