-
Notifications
You must be signed in to change notification settings - Fork 97
docs: Update CO2 injection example #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3661 +/- ##
===========================================
- Coverage 57.57% 57.43% -0.15%
===========================================
Files 1235 1234 -1
Lines 107102 106983 -119
===========================================
- Hits 61669 61444 -225
- Misses 45433 45539 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhuang2601
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkachuma Thanks for updating this case.
@margauxraguenel Please take a look on this fix.
margauxraguenel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on our side, perfect!
This PR updates the CO2 injection example to address the issues raised in #3660
The pvt files in this case were updated at #2933. However, the update to the
co2flash.txtfile was missed. I have therefore updated the example so that the actual files are referenced directly without having to duplicate them in the rst.The update at #2933 changed the ranges of pressure and temperature used to generate the PVT tables. These new values are more correct because they include the surface conditions required by the well. I cannot go back to the old ranges because now geos has a check to ensure that the well operates within the range of the PVT data.
According to the change at #2933, and also at #1065, I suspect the original images were generated with a temperature range that was too low. This led to the gas density being higher and therefore the gas not being as buoyant. When this was corrected, the gas became more buoyant as can be seen with the new results.
I have edited the case to make the images look a bit more like the original. I have halved the vertical permeability to curtail the gas migration upwards and reduced the porosity to 0.05 to ensure that the gas reaches the surface. The updated example has the new updated images.