Skip to content

Conversation

@frankfeifan
Copy link
Contributor

@frankfeifan frankfeifan commented Apr 24, 2025

This branch aims to implement the single-phase reactive transport model into GEOS. The following tasks are listed for completion:

  • A SinglePhaseReactiveTransport solver (derived from SinglePhaseBase) that contains all needed functions to solve the problem and SinglePhaseReactiveTransportFields.hpp to store all necessary fields
  • AccumulationKernel and FluxComputeKernel to assemble the local rhs and matrix
  • Make everything work for both isothermal and thermal
  • Plug in the chemistry module from this repo through a ReactiveSinglePhaseFluid constitutive model
  • A unit test testSinglePhaseReactiveTransport to verify the implementation of Jacobian matrix
  • Examples for representative reaction systems
  • A porosity model that updates the solid porosity with chemical reaction
  • Update surfaceArea (added but need test)
  • MoMaS verification (transport + all equilibrium) and generic chain reaction verification (transport + all kinetic)

@jhuang2601
Copy link
Contributor

jhuang2601 commented Dec 19, 2025

@frankfeifan @rrsettgast I move it to the testing queue, due to CI failures. Can you please fix these failures?

@frankfeifan
Copy link
Contributor Author

@frankfeifan @rrsettgast I move it to the testing queue, due to CI failures. Can you please fix these failures?

Yes. We're now working on the code style and documentation test failure. After fixing these two, we will just need to update the new integrated test id.

Copy link
Contributor

@herve-gross herve-gross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to avoid holding this up, but I have not looked at the code in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests flag: requires updated submodule(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants