-
Notifications
You must be signed in to change notification settings - Fork 97
feat: Single-phase reactive transport combined with HPCReact #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Single-phase reactive transport combined with HPCReact #3634
Conversation
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…d' into feature/singlePhaseReactiveTransportWithHPCReact
…ture/singlePhaseReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…d' into feature/singlePhaseReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
|
@frankfeifan @rrsettgast I move it to the testing queue, due to CI failures. Can you please fix these failures? |
Yes. We're now working on the code style and documentation test failure. After fixing these two, we will just need to update the new integrated test id. |
…eReactiveTransportWithHPCReact
…portWithHPCReact' into feature/singlePhaseReactiveTransportWithHPCReact
…thub.com:GEOS-DEV/GEOS into feature/singlePhaseReactiveTransportWithHPCReact
herve-gross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to avoid holding this up, but I have not looked at the code in detail.
This branch aims to implement the single-phase reactive transport model into GEOS. The following tasks are listed for completion:
SinglePhaseReactiveTransportsolver (derived fromSinglePhaseBase) that contains all needed functions to solve the problem andSinglePhaseReactiveTransportFields.hppto store all necessary fieldsAccumulationKernelandFluxComputeKernelto assemble the local rhs and matrixReactiveSinglePhaseFluidconstitutive modeltestSinglePhaseReactiveTransportto verify the implementation of Jacobian matrixsurfaceArea(added but need test)