Skip to content

build: Update to vtk9.4.2 and trilinos16.1.0 for Mac toolchain update #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rrsettgast merged 23 commits into from
Apr 29, 2025
Merged

build: Update to vtk9.4.2 and trilinos16.1.0 for Mac toolchain update #3626

rrsettgast merged 23 commits into from
Apr 29, 2025

Conversation

@rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Apr 17, 2025 •
edited
Loading

@rrsettgast rrsettgast self-assigned this Apr 17, 2025
@rrsettgast rrsettgast changed the title update: TPLs for Mac toolchain update build: TPLs for Mac toolchain update Apr 17, 2025
@rrsettgast rrsettgast marked this pull request as ready for review April 17, 2025 20:19
@rrsettgast rrsettgast requested review from CusiniM and bmhan12 April 17, 2025 20:53
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Apr 17, 2025
@rrsettgast rrsettgast mentioned this pull request Apr 18, 2025
Merged
3 tasks
CusiniM
CusiniM reviewed Apr 18, 2025
View reviewed changes
@rrsettgast rrsettgast added the ci: run code coverage enables running of the code coverage CI jobs label Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.66%. Comparing base (620bd4b) to head (574e7ae).
⚠️ Report is 47 commits behind head on develop.

Files with missing lines Patch % Lines
...reComponents/unitTests/meshTests/testVTKImport.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3626      +/-   ##
===========================================
- Coverage    56.66%   56.66%   -0.01%     
===========================================
  Files         1217     1217              
  Lines       105123   105123              
===========================================
- Hits         59565    59564       -1     
- Misses       45558    45559       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rrsettgast rrsettgast changed the title build: TPLs for Mac toolchain update build: Update to vtk9.4.2 and trilinos16.1.0 for Mac toolchain update Apr 29, 2025
@rrsettgast rrsettgast merged commit 0f56ffd into develop Apr 29, 2025
27 of 28 checks passed
@rrsettgast rrsettgast deleted the update/tplUpdate branch April 29, 2025 21:24
@alexbenedicto alexbenedicto mentioned this pull request May 23, 2025
Closed
danielemoretto44 pushed a commit that referenced this pull request Sep 22, 2025
@rrsettgast @CusiniM
build: Update to vtk9.4.2 and trilinos16.1.0 for Mac toolchain update (…
6cf48e4 
…#3626)

* update TPL tag

* add modified hostconfigs

* add explicit zlib import. update tpl tag

* add script to diff restart files that have different partitions

* change testVTKImport answers

---------

Co-authored-by: Matteo Cusini <49037133+CusiniM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CusiniM CusiniM CusiniM left review comments

@bmhan12 bmhan12 Awaiting requested review from bmhan12

@corbett5 corbett5 Awaiting requested review from corbett5

@wrtobin wrtobin Awaiting requested review from wrtobin

@MelReyCG MelReyCG Awaiting requested review from MelReyCG

Assignees

@rrsettgast rrsettgast

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rrsettgast @CusiniM