Skip to content

Conversation

@Algiane
Copy link
Contributor

@Algiane Algiane commented Jul 25, 2024

This PR fixes a few forgotten updates in the documentation after the merge of PR #3219.

@Algiane Algiane self-assigned this Jul 25, 2024
@Algiane Algiane requested a review from rrsettgast as a code owner July 25, 2024 12:16
@Algiane Algiane force-pushed the feature/algiane/fix-doc-after-PR#3219 branch from f195c41 to 88cf616 Compare July 25, 2024 12:18
@Algiane Algiane changed the title Fix wrong variable names in doc after PR #3219 (GEOSX_ -> GEOS_). docs: Fix wrong variable names in doc after PR #3219 (GEOSX_ -> GEOS_). Jul 25, 2024
@Algiane Algiane added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: no rebaseline Does not require rebaseline labels Jul 25, 2024
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.83%. Comparing base (9cf5ab5) to head (88cf616).
Report is 80 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3242   +/-   ##
========================================
  Coverage    55.83%   55.83%           
========================================
  Files         1042     1042           
  Lines        88654    88654           
========================================
  Hits         49501    49501           
  Misses       39153    39153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jul 25, 2024
@rrsettgast rrsettgast merged commit 52d15b8 into develop Jul 26, 2024
@rrsettgast rrsettgast deleted the feature/algiane/fix-doc-after-PR#3219 branch July 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants