Skip to content

Conversation

@klevzoff
Copy link
Contributor

@klevzoff klevzoff commented May 9, 2023

This is a collection of LAI-related changes extracted from my multiscale branch to be reviewed separately. I will post some comments later highlighting the most important changes.

Rebaseline needed due to change in default linear solver parameters.

@klevzoff klevzoff requested a review from castelletto1 May 9, 2023 09:26
@klevzoff klevzoff self-assigned this May 9, 2023
@klevzoff klevzoff added the flag: requires rebaseline Requires rebaseline branch in integratedTests label May 10, 2023
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch 2 times, most recently from 6aa101b to a167fdc Compare May 12, 2023 06:12
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch 2 times, most recently from dfbc927 to 742c689 Compare July 18, 2023 09:09
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 742c689 to 9004d43 Compare October 8, 2023 01:45
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 9004d43 to 2bb59cd Compare January 7, 2024 07:58
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 2bb59cd to efde4b5 Compare June 1, 2025 07:59
@klevzoff klevzoff requested review from dkachuma and tjb-ltk as code owners June 1, 2025 07:59
@klevzoff klevzoff changed the title Linear algebra updates feat: Linear algebra updates Jun 1, 2025
@klevzoff klevzoff added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

❌ Patch coverage is 44.84761% with 380 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.35%. Comparing base (9142e88) to head (e9bae11).
⚠️ Report is 100 commits behind head on develop.

Files with missing lines Patch % Lines
...ts/linearAlgebra/interfaces/hypre/HypreKernels.hpp 0.00% 67 Missing ⚠️
...nts/linearAlgebra/interfaces/hypre/HypreMatrix.cpp 32.55% 58 Missing ⚠️
...ents/linearAlgebra/solvers/BlockPreconditioner.cpp 0.00% 58 Missing ⚠️
...ents/linearAlgebra/interfaces/hypre/HypreUtils.cpp 47.88% 37 Missing ⚠️
...nts/linearAlgebra/utilities/LAIHelperFunctions.hpp 0.00% 25 Missing ⚠️
...ers/solidMechanics/SolidMechanicsLagrangianFEM.cpp 4.16% 23 Missing ⚠️
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 20 Missing ⚠️
...arAlgebra/interfaces/hypre/HyprePreconditioner.cpp 25.00% 15 Missing ⚠️
...echanics/contact/SolidMechanicsLagrangeContact.cpp 0.00% 13 Missing ⚠️
...Components/linearAlgebra/interfaces/MatrixBase.hpp 45.45% 12 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2427      +/-   ##
===========================================
- Coverage    58.37%   58.35%   -0.02%     
===========================================
  Files         1261     1264       +3     
  Lines       108697   109013     +316     
===========================================
+ Hits         63450    63619     +169     
- Misses       45247    45394     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 1f0eaad to 13396c6 Compare August 4, 2025 07:16
Copy link
Contributor

@castelletto1 castelletto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @klevzoff!

@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 13396c6 to ce77dbf Compare August 5, 2025 05:09
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch 3 times, most recently from 941dbff to d026da0 Compare August 9, 2025 20:53
@klevzoff
Copy link
Contributor Author

Need codeowners approval @rrsettgast

@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from d026da0 to 9da673f Compare August 10, 2025 03:43
@klevzoff klevzoff force-pushed the feature/klevzoff/linear-algebra-updates branch from 9da673f to 1c36975 Compare August 10, 2025 23:49
Copy link
Contributor

@herve-gross herve-gross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing of value to add for me here, but I do not want to hold it behind. Thanks!

@klevzoff klevzoff merged commit 5a05089 into develop Aug 14, 2025
26 of 28 checks passed
@klevzoff klevzoff deleted the feature/klevzoff/linear-algebra-updates branch August 14, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants