Refactored compositional flow unit tests #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoishamon
added
type: cleanup / refactor
TotoGaz
approved these changes
Mar 8, 2022
|
|
||
| void testPhaseVolumeFractionNumericalDerivatives( CompositionalMultiphaseFVM & solver, | ||
| DomainPartition & domain, | ||
| bool const isThermal, |
Contributor
There was a problem hiding this comment.
So the isThermal is currently never true?
Contributor
Author
There was a problem hiding this comment.
Yes, I confirm that the isThermal is currently never true (until PR #1225 is merged). I am trying to take small steps towards thermal to avoid doing everything in the same PR. So currently,
- There is already a flag
isThermalin the solver, currently alwaysfalse. - There is already some extrinsic data available in the solver for temperature, currently only modified at initialization.
- The present PR adds the unit tests functions to check derivatives wrt temperature, but they are currently unused.
PR #1225 will put everything together, allow the flag isThermal to be true, allow the temperature field to change with time, and will add a unit test using the functions added in the present PR.
francoishamon
added
ci: run CUDA builds
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the unit tests:
testCompMultiphaseFlowandtestCompMultiphaseFlowHybridby removing some duplicate code and moving unified functions totestCompFlowUtils.hpp.The goal is to be able to add a thermal unit test in #1225 without adding much code. I am doing the present refactoring in a separate PR to avoid clutter in #1225.
Ready for review.