utils interface #47
Merged
utils interface #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new utils interface module that provides FastEdge-specific handlers, specifically for setting user diagnostics. The main changes include:
- Addition of a new
utilsmodule with aset_user_diagfunction for saving statistics user diagnostic messages - Renaming of internal
utilsmodule tohelperto avoid naming conflicts - Updates to existing code to reference the renamed
helpermodule
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wit | Updated subproject commit reference |
| src/proxywasm/utils.rs | New file implementing the utils interface with set_user_diag function |
| src/proxywasm/mod.rs | Added utils module declaration and FFI binding for stats_set_user_diag |
| src/proxywasm/key_value.rs | Updated imports from utils to helper and added Display implementation for Error |
| src/lib.rs | Renamed internal utils module to helper and exposed new public utils module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix method description Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix extraspace Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
qrdl
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.