Skip to content

Conversation

@ruslanti
Copy link
Collaborator

@ruslanti ruslanti commented Nov 3, 2025

…urn type

@ruslanti ruslanti requested review from Copilot and qrdl November 3, 2025 08:44
@ruslanti ruslanti self-assigned this Nov 3, 2025
@ruslanti ruslanti added the enhancement New feature or request label Nov 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the zrange method to zrange_by_score for better clarity and updates the return type to include scores alongside values. This change makes the API more explicit about its functionality and provides additional information in the response.

  • Renamed zrange method to zrange_by_score across the trait and implementations
  • Updated return type from Vec<Value> to Vec<(Value, f64)> to include scores
  • Changed Redis implementation to use zrangebyscore_withscores instead of zrangebyscore

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk Subproject commit update
crates/key-value-store/src/redis_impl.rs Updated Redis implementation to use new method name and return scores
crates/key-value-store/src/lib.rs Updated trait definition and all implementations with new method signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ruslanti ruslanti requested review from Copilot and qrdl November 3, 2025 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ruslanti ruslanti merged commit fccf625 into main Nov 4, 2025
8 of 9 checks passed
@ruslanti ruslanti deleted the feat/436-kv-store-improvements branch November 4, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants