fix: reduce info logging level to debug #106
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces the logging verbosity by downgrading two informational log statements from info to debug level. This prevents excessive logging during normal operations while keeping error and exceptional conditions at the info level.
- Changed "Processing request" log statement to debug level to reduce per-request noise
- Changed "Added to cache" log statement to debug level as it's an internal implementation detail
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/http-service/src/lib.rs | Downgraded "Processing request" log from info to debug to reduce verbosity on every successful request |
| crates/http-service/src/executor/http.rs | Downgraded "Added to cache" log from info to debug as it represents internal caching behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let component = self.loader().load_component(cfg.binary_id)?; | ||
| let instance_pre = engine.component_instantiate_pre(&component)?; | ||
| tracing::info!("Added '{}' to cache", name); | ||
| tracing::debug!("Added '{}' to cache", name); |
There was a problem hiding this comment.
BTW does our cache works ok? Maybe it is too small? I remember seeing too many Added to cache messages in log when I expect the binary to be cached because it was called recently. I propose to leave this message as info to monitor cache
| // lookup for application config and binary_id | ||
| tracing::info!( | ||
| tracing::debug!( | ||
| "Processing request for application '{}' on URL: {}", |
There was a problem hiding this comment.
Do we have any other log message for new request?
There was a problem hiding this comment.
yes, we have one for completed with success or failure
No description provided.