-
Notifications
You must be signed in to change notification settings - Fork 0
Icm 43582 vulnerability report blind ssrf at html rewriter.fastedge.gcore.dev lead to internal port #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a blind SSRF vulnerability (ICM-43582) by implementing host validation to prevent requests to private/internal IP addresses and ports. The changes add security checks that reject requests targeting private networks, localhost, and other restricted IP ranges.
Key changes:
- Added private IP address validation for both IPv4 and IPv6 addresses
- Implemented host validation checks in HTTP backend and service layers
- Refactored key-value store operations to improve type safety and error handling
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/http-backend/src/lib.rs | Added is_public_host() function and comprehensive private IP detection for IPv4/IPv6 to prevent SSRF attacks |
| crates/http-service/src/state.rs | Added host validation check using is_public_host() before processing backend requests |
| crates/key-value-store/src/lib.rs | Renamed zrange to zrange_by_score and updated return type to include scores |
| crates/key-value-store/src/redis_impl.rs | Updated Redis operations to match new interface and improved error handling |
| crates/key-value-store/Cargo.toml | Upgraded Redis dependency to 0.32 with additional features for safe iterators |
| crates/runtime/src/app.rs | Added serde(default) to param field and added comprehensive tests for deserialization |
| crates/reactor/src/lib.rs | Updated WIT path from SDK submodule to local reactor wit directory |
| .gitmodules | Changed submodule from SDK to FastEdge-wit repository |
| Cargo.toml | Version bump to 0.13.2 |
| CHANGELOG.md | Added release notes for versions 0.13.1 and 0.13.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
55b5062 to
0d86c18
Compare
…package versions to 0.13.0-2
qrdl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of Copilot comments make sense, please take a look
No description provided.