Faderport 14 bit fader -> two byte key #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a Novation LaunchKey mk4. It can transmit 14-bit fader and encoder data, and uses an MSB/LSB encoding via CC parameters separated by 20h. This is captured perfectly by the FaderportClassicFader14Bit message generator type.
However, the FaderportClassicFader14Bit message generator uses a one-byte key, which means that it hogs all possible CC parameters on a given channel. The Novation sends slider data for multiple faders and pots via MSB/LSB CC pairs on the same channel, and as such does not work with the FaderportClassicFader14Bit message generator as it stands now.
As far as I can tell, there is no reason for this message generator to use only a one-byte key. This pull request updates it to use a two-byte key, which means that it works not only with the Faderport Classic, but also the Novation range. (Actually, there are now two two-byte keys: one for the MSB and one for the LSB.)