[BUGFIX] Fix Scripted Class Extending not working with multiple scripted layers#401
Open
TechnikTil wants to merge 1 commit intoFunkinCrew:experimentalfrom
Open
Conversation
TechnikTil
force-pushed
the
bugfix/scripted-class-layer-properly
branch
from
5ce31f2 to
40a748d
Compare
…pted classes Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
TechnikTil
force-pushed
the
bugfix/scripted-class-layer-properly
branch
from
40a748d to
1742f07
Compare
Author
|
Updated the code to use less lines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is currently a bug with
HScriptedClassMacrowhere after multiple layers of scripted class extending, it would not detect any layers except the first two. This PR fixes that by making the super lookup recursive.More Info about the Bug
By applying this patch, the
openfl_hscript_classexample will include two new stages inmod8. "Even Less Basic Stage" should not work unless this PR is the base. This is due to it extending "Less Basic Stage", which extends "Basic Stage".