[REFACTOR] Clean up HScriptedClassMacro#399
Open
NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
Open
[REFACTOR] Clean up HScriptedClassMacro#399NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
HScriptedClassMacro#399NotHyper-474 wants to merge 1 commit intoFunkinCrew:experimentalfrom
Conversation
|
|
peak |
NotHyper-474
force-pushed
the
hscripted-macro-cleanup
branch
2 times, most recently
from
6aacb4d to
a4ce778
Compare
NotHyper-474
force-pushed
the
hscripted-macro-cleanup
branch
from
a4ce778 to
d2d421b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the
HScriptedClassMacroclass readability by improving the usage of features of the Haxe language throughout the code.Removes unused local variables and code.
Applies the use of
Context.followto get rid ofTLazy(constructors don't like this though, so not for them...)Adds the needed imports for the types it uses and replaces the use of the full module name where those are referenced.
Simplifies the checks for metadata.
Moves the check for
displaymode to before the field overriding and after the addition of the basic functions (scriptInit,scriptGet, etc.) to prevent issues with errors about those not being found on the language server.Improves the usage of pattern matching in switch cases to reduce verbosity and/or boilerplate.