Open
Conversation
Starexify
suggested changes
Feb 27, 2026
|
|
||
| // ----------------------------------------------------------------------------------------------- | ||
| public function getMetadata(modId:String) | ||
| public function getMetadata(modId:String, ?origin:PolymodErrorOrigin):Void |
There was a problem hiding this comment.
I think this should return Null<ModMetadata> not Void 😅
Hundrec
force-pushed
the
error-code-rework
branch
from
7251d4e to
8aab0b0
Compare
Member
|
Rebased on top of Checked that it works. Once Eric addresses the comments, this should be good to go! |
…t error codes for trying to load an outdated mod!)
Hundrec
force-pushed
the
error-code-rework
branch
from
8aab0b0 to
d70a22c
Compare
Starexify
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PolymodErrorCode enum was super disorganized (there were two different error codes for trying to load a mod that's outdated for instance), so I refactored it and a bunch of the places in Polymod where it got used.
Part of a change to resolve FunkinCrew/Funkin#6992.