Skip to content

[BUGFIX] Fix characters with global offsets not getting properly moved in the Stage Editor#7002

Merged
Hundrec merged 1 commit intoFunkinCrew:dummy/develop-v0.8.3from
KoloInDaCrib:stay-in-yo-damn-place-brah
Mar 10, 2026
Merged

[BUGFIX] Fix characters with global offsets not getting properly moved in the Stage Editor#7002
Hundrec merged 1 commit intoFunkinCrew:dummy/develop-v0.8.3from
KoloInDaCrib:stay-in-yo-damn-place-brah

Conversation

@KoloInDaCrib
Copy link
Copy Markdown
Contributor

Linked Issues

Closes #6995

Description

The issue was basically that, because offsets get applied in getScreenPosition(), the calculation gets messed up every time a character with offsets was getting moved with the mouse in the Stage Editor.

Screenshots/Videos

i.had.to.convert.this.video.because.it.was.10.8mb.mp4

@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Feb 25, 2026
@KoloInDaCrib KoloInDaCrib force-pushed the stay-in-yo-damn-place-brah branch from 257d521 to 45697ba Compare February 25, 2026 12:48
@github-actions github-actions Bot added the size: medium A medium pull request with 100 or fewer changes. label Feb 25, 2026
@Hundrec Hundrec self-requested a review February 27, 2026 02:22
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: stage editor Related to the operation of the Stage Editor. labels Feb 27, 2026
@Hundrec Hundrec linked an issue Feb 27, 2026 that may be closed by this pull request
4 tasks
@Marcosayfi
Copy link
Copy Markdown
Contributor

nice. i've had this bug for a while.

Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely enough, this is still completely broken for me
It doesn't seem to behave differently between 0.8.3 release and develop
When I click on any character, it flies away from my mouse at lightspeed

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Mar 4, 2026
@KoloInDaCrib KoloInDaCrib force-pushed the stay-in-yo-damn-place-brah branch 2 times, most recently from 50c67c8 to 3398714 Compare March 5, 2026 19:34
@github-actions github-actions Bot added size: small A small pull request with 10 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Mar 5, 2026
@VirtuGuy
Copy link
Copy Markdown
Contributor

VirtuGuy commented Mar 5, 2026

FlxG.mouse has deltaX and deltaY. Why not just add those variables to the character's position? That way, you won't have to worry too much about global offsets.

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Mar 6, 2026
@Hundrec Hundrec self-requested a review March 6, 2026 12:21
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've double-checked that I've pulled this in correctly, but it still does that weird characters-flying-away thing
I'd really like to get this fixed before the next patch

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Mar 6, 2026
@KoloInDaCrib KoloInDaCrib force-pushed the stay-in-yo-damn-place-brah branch from 3398714 to 0019374 Compare March 7, 2026 09:23
@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Mar 7, 2026
@Hundrec Hundrec removed the status: needs revision Cannot be approved because it is awaiting some work by the contributor. label Mar 7, 2026
@Hundrec Hundrec added the status: reviewing internally Under consideration and testing. label Mar 7, 2026
@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.8.3 March 10, 2026 02:13
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Mar 10, 2026
@Hundrec Hundrec added this to the 0.8.4 milestone Mar 10, 2026
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did it

@Hundrec Hundrec merged commit df088b8 into FunkinCrew:dummy/develop-v0.8.3 Mar 10, 2026
6 checks passed
@KoloInDaCrib KoloInDaCrib deleted the stay-in-yo-damn-place-brah branch March 10, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: stage editor Related to the operation of the Stage Editor. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

Bug Report: Stage Editor reapplies offsets when selecting character with mouse

4 participants