Skip to content

[ENHANCEMENT] Smooth lerp scaling for Touch to Play button#6966

Closed
AnimatingLegend wants to merge 1 commit intoFunkinCrew:developfrom
AnimatingLegend:touch-to-play-lerp
Closed

[ENHANCEMENT] Smooth lerp scaling for Touch to Play button#6966
AnimatingLegend wants to merge 1 commit intoFunkinCrew:developfrom
AnimatingLegend:touch-to-play-lerp

Conversation

@AnimatingLegend
Copy link
Copy Markdown
Contributor

@AnimatingLegend AnimatingLegend commented Feb 22, 2026

Description

Updated touchHereToPlay button in FunkinPreloader.hx to make it feel more polished, instead of scale jumping instantly.

Changes:

  • Added a lerp calculation so the sprite's scale catches up to the target scale.
  • Swapped MOUSE_OVER and MOUSE_OUT events out for a hitTestPoint() check.
  • Added logic to handle a small scale when the mouse is pressed.
  • Implemented a small delay timer in mouseDownTouchHereToPlay() to allow the button to quickly 'rise up' before the game starts.
  • Left old mouse functions blank since the scaling is now being handled in updateGraphics().

Screenshots/Videos

Before (itch.io build):

2026-02-22.00-26-47.mp4

After (FINAL):

2026-02-22.15-36-27.mp4

@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Feb 22, 2026
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Feb 22, 2026
@AnimatingLegend AnimatingLegend force-pushed the touch-to-play-lerp branch 2 times, most recently from 7f6b98e to 6c615a5 Compare February 22, 2026 22:00
@AnimatingLegend AnimatingLegend force-pushed the touch-to-play-lerp branch 2 times, most recently from 4ea225d to eac8684 Compare March 10, 2026 18:03
@EliteMasterEric EliteMasterEric added this to the 0.8.4 milestone Mar 10, 2026
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Mar 12, 2026
@Hundrec Hundrec removed this from the 0.8.4 milestone Mar 12, 2026
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and clicking on the Touch here to play button doesn't do anything.

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: reviewing internally Under consideration and testing. labels Mar 15, 2026
@AnimatingLegend
Copy link
Copy Markdown
Contributor Author

I tested this and clicking on the Touch here to play button doesn't do anything.

Well, what do you want the button to do? I honestly just added a tween to the button to make it more visually appealing when hovering and clicking. I didn't really think that far ahead

- Added a lerp calculation so the sprite's scale catches up to the target scale.
- Swapped `MOUSE_OVER` and `MOUSE_OUT` events out for a `hitTestPoint()` check.
- Added logic to handle a small scale when the mouse is pressed.
- Implemented a small delay timer in `mouseDownTouchHereToPlay()` to allow the button to quickly 'rise up' before the game starts.
- Left old mouse functions blank since the scaling is now being handled in `updateGraphics()`.
@Hundrec
Copy link
Copy Markdown
Member

Hundrec commented Apr 4, 2026

We ended up implementing this in our own way. Thanks for your submission!

@Hundrec Hundrec closed this Apr 4, 2026
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed type: enhancement Involves an enhancement or new feature. status: needs revision Cannot be approved because it is awaiting some work by the contributor. pr: haxe PR modifies game code. labels Apr 4, 2026
@AnimatingLegend AnimatingLegend deleted the touch-to-play-lerp branch April 4, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: medium A medium pull request with 100 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.

Development

Successfully merging this pull request may close these issues.

3 participants