fix: avoid variable shadowing of timestep t in compute_loss#1826
Open
Mr-Neutr0n wants to merge 1 commit intoFunAudioLLM:mainfrom
Open
fix: avoid variable shadowing of timestep t in compute_loss#1826Mr-Neutr0n wants to merge 1 commit intoFunAudioLLM:mainfrom
t in compute_loss#1826Mr-Neutr0n wants to merge 1 commit intoFunAudioLLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
cosyvoice/flow/flow_matching.py, thecompute_loss()method has a variable shadowing issue wheret(the sequence length integer from shape unpacking) is immediately overwritten byt(the random timestep tensor):The integer
tfrom the shape unpacking is never used before being reassigned. While this doesn't cause a runtime error in the current code, it is misleading and fragile — a future developer might assumetstill holds the sequence length after the unpacking line, leading to subtle bugs.Fix
Replace
b, _, t = mu.shapewithb, _, _ = mu.shapeto make it explicit that only the batch dimensionbis needed from the shape, and that the subsequenttis solely the random timestep tensor.Test plan
t(sequence length) is not referenced anywhere between the unpacking and the reassignment