-
Notifications
You must be signed in to change notification settings - Fork 10
Adds amber scenario. #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CdavM
wants to merge
1
commit into
Froot-NetSys:a2a-agentx
Choose a base branch
from
RDI-Foundation:cdavm/amber
base: a2a-agentx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,5 @@ | |
| **/*.pyo | ||
| Dockerfile | ||
| .git | ||
| .gitignore | ||
| .gitignore | ||
| amber/.env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,4 +28,4 @@ app-route/*.txt | |
| app-malt/=0.26.0 | ||
| app-k8s/policies/* | ||
| app-k8s/pod_deployment/* | ||
| app-k8s/test.txt | ||
| app-k8s/test.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| manifest_version: "0.1.0", | ||
| program: { | ||
| image: "ghcr.io/froot-netsys/malt_agent:latest", | ||
| entrypoint: [ | ||
| "uv", | ||
| "run", | ||
| "malt_agent.py", | ||
| "--host", | ||
| "0.0.0.0", | ||
| "--port", | ||
| "8081" | ||
| ], | ||
| env: { | ||
| PROXY_URL: "${slots.proxy.url}", | ||
| LOG_LEVEL: "INFO", | ||
| }, | ||
| network: { | ||
| endpoints: [ | ||
| { name: "endpoint", port: 8081 }, | ||
| ], | ||
| }, | ||
| }, | ||
| config_schema: { | ||
| type: "object", | ||
| properties: { | ||
| }, | ||
| required: [], | ||
| additionalProperties: false, | ||
| }, | ||
| slots: { | ||
| proxy: { kind: "a2a" }, | ||
| }, | ||
| provides: { | ||
| a2a: { kind: "a2a", endpoint: "endpoint" }, | ||
| }, | ||
| exports: { | ||
| a2a: "a2a", | ||
| }, | ||
| metadata: { | ||
| assessment_config: { | ||
| prompt_type: "zeroshot_base", | ||
| num_queries: 2, | ||
| max_iterations: 10, | ||
| output_dir: "dump", | ||
| benchmark_path: "assessment_error_config.json", | ||
| regenerate_benchmark: true, | ||
| num_switches: 2, | ||
| num_hosts_per_subnet: 1 | ||
| }, | ||
| participant_roles: [ | ||
| "route_operator" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| AMBER_CONFIG_OPENAI_API_KEY= |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entrypoint should be running the
./start_route_agent.shin place ofuv run malt_agent.pyand using the route_agent image (I'm assuming this is for route app?). Also, this container needs to be run with--privilegedand mount/lib/modules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kolleida! I believe it's not possible to run an image with
--privilegedin amber. This is why we went with the MALT agent instead. Is there another way we can run your benchmark via amber? Please let me know what image/entrypoint/config parameters to use. Thank you!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CdavM If you are running MALT, then the role should be
"malt_operator", not"route_operator"(this was mainly used by the leaderboard query to filter MALT specific results). Also, the config should look something like this:This config generates 30 queries in total spread across the 3 levels. Increasing
num_queriesadds 10 queries (you can choose how much you think is appropriate for good signal).Later I saw the agentbeats version of NetArena on the website, and the description references the K8s benchmark, but you guys are doing MALT instead. Is this also because the setup needed (e.g. boostrap a KIND cluster) is impossible/hard to express in amber?