Skip to content

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Jan 17, 2026

No description provided.

johnbillion and others added 4 commits January 15, 2026 08:19
These files aren't needed in the Composer package.
PHP 7.2 requires at least libcurl 7.10.5 so the check is always true on all supported PHP versions:
https://github.com/php/php-src/blob/php-7.2.0/ext/curl/config.m4#L34

PHP 7.3 bumps the minimum to 7.15.5 but, even when we drop support for PHP < 7.4, that won’t help us with cleanups:
https://github.com/php/php-src/blob/php-7.3.0/ext/curl/config.m4#L32

PHP 8.0 further bumps this to 7.29.0, which would allow us to remove the remaining conditionals, but we still support 7.2.0 for now and will support 7.4.0 for a while.
https://github.com/php/php-src/blob/php-8.0.0/ext/curl/config.m4#L7
Fixes date parsing behavior when encountering invalid or localized date formats.

Before (on PHP 7.4):
- Invalid dates could throw errors/warnings due to `strict_types`

Before (on PHP 8.*):
- Invalid dates returned current date when not properly parsed (`date` uses current time when passed null)

After:
- Invalid dates gracefully return null
- Consistent behavior for different PHP versions

Changes:
- Improved error handling in date parsing
- Added test coverage for RFC 2822 formatted dates
- Added test for custom format parameter
@Alkarex Alkarex changed the base branch from master to freshrss January 17, 2026 10:44
@Alkarex Alkarex merged commit ecc7ef1 into freshrss Jan 17, 2026
20 checks passed
@Alkarex Alkarex deleted the merge-upstream branch January 17, 2026 10:45
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jan 17, 2026
Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants