stream_buffer: require batching buffers to exceed the trigger level#1396
Open
officialasishkumar wants to merge 1 commit intoFreeRTOS:mainfrom
Open
stream_buffer: require batching buffers to exceed the trigger level#1396officialasishkumar wants to merge 1 commit intoFreeRTOS:mainfrom
officialasishkumar wants to merge 1 commit intoFreeRTOS:mainfrom
Conversation
Batching stream buffers are documented to unblock receivers only after the buffered byte count exceeds the trigger level, but both xStreamBufferSend() paths currently notify as soon as the count reaches it. That equality case wakes the blocked receiver too early, causing xStreamBufferReceive() to return 0 bytes while the buffer still holds exactly trigger-level data. Route both task and ISR send paths through a shared trigger helper so batching buffers require a strict greater-than check while existing stream and message buffer semantics remain unchanged. Fixes FreeRTOS#1375 Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Batching stream buffers are documented to unblock receivers only after the buffered byte count exceeds the trigger level. Both
xStreamBufferSend()andxStreamBufferSendFromISR()currently notify as soon as the count reaches that level, which wakes a blocked receiver too early and can makexStreamBufferReceive()return0bytes while the buffer still holds exactly trigger-level data.This change routes both send paths through a shared helper so batching buffers require a strict greater-than check, while stream and message buffers keep their existing trigger semantics.
Test Steps
FreeRTOS/Test/CMock/stream_buffer/apiharness against the updatedFreeRTOS-Kernelworking tree.Checklist:
Related Issue
#1375
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.