Correct RISC-V port #endif preprocessor comments#1395
Merged
patrzhan merged 1 commit intoFreeRTOS:mainfrom Apr 3, 2026
Merged
Conversation
The comment after vPortSetupTimerInterrupt in GCC and IAR RISC-V port.c duplicated configMTIME_BASE_ADDRESS and omitted configMTIMECMP_BASE_ADDRESS. Align the comment with the matching #if condition.
patrzhan
force-pushed
the
fix/riscv-port-endif-comment
branch
from
d9ceebc to
03132e4
Compare
|
patrzhan
approved these changes
Apr 3, 2026
Member
|
Thank you for your contribution. The change looks good to me. |
AniruddhaKanhere
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
#endifcomment aftervPortSetupTimerInterruptin GCC and IAR RISC-Vport.c: the comment duplicatedconfigMTIME_BASE_ADDRESSand did not mentionconfigMTIMECMP_BASE_ADDRESS, unlike the matching#ifcondition.Files
portable/GCC/RISC-V/port.cportable/IAR/RISC-V/port.cThis is a comment-only fix; preprocessor behavior is unchanged.