Remove github_token input, correct for SBOM file placement#1391
Merged
kstribrnAmzn merged 2 commits intoFreeRTOS:mainfrom Mar 30, 2026
Merged
Remove github_token input, correct for SBOM file placement#1391kstribrnAmzn merged 2 commits intoFreeRTOS:mainfrom
kstribrnAmzn merged 2 commits intoFreeRTOS:mainfrom
Conversation
Inputs need to be literal, static values.
Instead we should simply use `${{ secrets.GITHUB_TOKEN }}`
which is resolved at runtime
AniruddhaKanhere
previously approved these changes
Mar 30, 2026
felicityzhao9
previously approved these changes
Mar 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 91.46% 91.37% -0.09%
==========================================
Files 6 6
Lines 3256 3259 +3
Branches 899 902 +3
==========================================
Hits 2978 2978
Misses 132 132
- Partials 146 149 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The SBOM generator currently outputs the files at the workspace root.
kstribrnAmzn
dismissed stale reviews from felicityzhao9 and AniruddhaKanhere
via
35ba942
|
kstribrnAmzn
changed the title
AniruddhaKanhere
approved these changes
Mar 30, 2026
archigup
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inputs need to be literal, static values.
Instead we should simply use
${{ secrets.GITHUB_TOKEN }}which is resolved at runtimeUpdate the SBOM commit step to copy the SBOM generated files into the current working directory
rather than the github root directory.
Test Steps
Ran the workflow on my fork - https://github.com/kstribrnAmzn/FreeRTOS-Kernel/actions/runs/23773106587/job/69268848671
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.